lkml.org 
[lkml]   [2011]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 05/10] vmscan: make isolate_lru_page with filter aware
    On Thu, Jun 09, 2011 at 03:04:53PM +0100, Mel Gorman wrote:
    > On Tue, Jun 07, 2011 at 11:38:18PM +0900, Minchan Kim wrote:
    > > In __zone_reclaim case, we don't want to shrink mapped page.
    > > Nonetheless, we have isolated mapped page and re-add it into
    > > LRU's head. It's unnecessary CPU overhead and makes LRU churning.
    > >
    >
    > Gack, I should have keep reading. I didn't cop from the subject that

    I should have used clear subject.

    > __zone_reclaim would be updated. Still, it would have been easier to
    > review if one patch introduced ISOLATE_CLEAN and updated the callers and
    > this patch introduced ISOLATE_UNMAPPED and updated the relevant callers.

    Agree. I will fix in later version.

    >
    > > <SNIP>
    >
    > --
    > Mel Gorman
    > SUSE Labs

    --
    Kind regards
    Minchan Kim


    \
     
     \ /
      Last update: 2011-06-09 17:05    [W:0.105 / U:3.268 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site