Messages in this thread | | | Subject | Re: Change in functionality of futex() system call. | From | Peter Zijlstra <> | Date | Thu, 09 Jun 2011 14:05:08 +0200 |
| |
On Mon, 2011-06-06 at 20:11 +0200, Eric Dumazet wrote:
> Now, what if other software uses a MAP_PRIVATE ro mapping ? > > It was working in previous kernels as well. > > We can say its stupid, but IMHO its not. > > In other words, this program should work, if process never touches > (writes) into first page. > > This program on previous kernels gave : > rc=-1 errno=11 > (allowing to wait for a value change and a futex_WAKE) > > With new kernel : > rc=-1 errno=14 [ no sleep allowed ]
Yeah, so friggin what? I can write a similar program that is broken with the old behaviour. The fact that the semantics are just crap (wtf does it mean to FUTEX_WAIT on a address that changes mapping on COW) should be enough to convince you that the old behaviour simply doesn't make sense.
Once the COW happened you shouldn't be able to observe the old page, yet that's exactly what the still pending FUTEX_WAIT will do.
The fact that this can happen, means the behaviour is broken, no if else or buts about it.
| |