| Date | Thu, 9 Jun 2011 11:17:54 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH v4 3.0-rc2-tip 13/22] 13: uprobes: Handing int3 and singlestep exception. |
| |
> > + */ > > +int uprobe_post_notifier(struct pt_regs *regs) > > +{ > > + struct uprobe *uprobe; > > + struct uprobe_task *utask; > > + > > + if (!current->mm || !current->utask || !current->utask->active_uprobe) > > + /* task is currently not uprobed */ > > + return 0; > > + > > + utask = current->utask; > > + uprobe = utask->active_uprobe; > > + if (!uprobe) > > + return 0; > > + > > + set_thread_flag(TIF_UPROBE); > > + return 1; > > +} > > Looks like this can be simplified. If current->utask->active_uprobe is > non-null then surely the assignment to uprobe will be too? >
Yes, the two lines where we check for !uprobe and return are redundant and can be removed. Will be corrected in the next patchset.
-- Thanks and Regards Srikar
|