lkml.org 
[lkml]   [2011]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 8 Jun 2011 20:45:07 -0700
FromJosh Triplett <>
SubjectRe: [PATCH tip/core/rcu 03/28] rcu: Streamline code produced by __rcu_read_unlock()
On Wed, Jun 08, 2011 at 12:29:42PM -0700, Paul E. McKenney wrote:
> Given some common flag combinations, particularly -Os, gcc will inline
> rcu_read_unlock_special() despite its being in an unlikely() clause.
> Use noline to prohibit this misoptimization.

If rcu_read_unlock_special only gets called in the one place, why does
it hurt to inline it, as long as the inlined code stays on the cold
path? Might as well remove the overhead of the function call.

- Josh Triplett


\
 
 \ /
  Last update: 2011-06-09 05:47    [from the cache]
©2003-2010