Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 8 Jun 2011 13:53:48 -0700 | Subject | Re: [debug patch] printk: Add a printk killswitch to robustify NMI watchdog messages |
| |
On Wed, Jun 8, 2011 at 1:32 PM, Peter Zijlstra <peterz@infradead.org> wrote: > > atomic_down() is a tad iffy, it would have to wait for an actual > semaphore owner, which might sleep etc.. So I skipped it.
I think sleeping would be fine: the "atomic" part is about the code the semaphore protects, not about the down() itself.
But the way you made the semantics be (caller has to disable interrupts) for the other helpers, that doesn't really work.
Linus
| |