Messages in this thread | | | Subject | Re: [debug patch] printk: Add a printk killswitch to robustify NMI watchdog messages | From | Peter Zijlstra <> | Date | Wed, 08 Jun 2011 21:45:29 +0200 |
| |
On Wed, 2011-06-08 at 21:17 +0200, Ingo Molnar wrote: > Hm, the no-wakeup aspect seems rather useful. > > Could we perhaps remove console_sem and replace it with a mutex and > do something like this with a mutex and its ->wait_lock? > > We'd have two happy side effects: > > - we'd thus remove one of the last core kernel semaphore users > - we'd gain lockdep coverage for console locking as a bonus ...
The mutex thing is more complex due to the mutex fast path, the advantage of the semaphore is its simple implementation that always takes the internal lock.
I guess I can make it happen, but its a tad more tricky.
| |