Messages in this thread | | | Date | Wed, 8 Jun 2011 12:11:05 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH 3/4] mm: memory-failure: Fix isolated page count during memory failure |
| |
On Wed 08-06-11 12:07:20, Michal Hocko wrote: > On Tue 07-06-11 16:07:04, Mel Gorman wrote: > > From: Minchan Kim <minchan.kim@gmail.com> > > > > From: Minchan Kim <minchan.kim@gmail.com> > > > > Pages isolated for migration are accounted with the vmstat counters > > NR_ISOLATE_[ANON|FILE]. Callers of migrate_pages() are expected to > > increment these counters when pages are isolated from the LRU. Once > > the pages have been migrated, they are put back on the LRU or freed > > and the isolated count is decremented. > > Aren't we missing this in compact_zone as well? AFAICS there is no > accounting done after we isolate pages from LRU? Or am I missing > something?
Scratch that. It was hidden in acct_isolated which is called from isolate_migratepages. It would be really strange if this was broken ;)
-- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic
| |