lkml.org 
[lkml]   [2011]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] Fix mismatched variable in rcutree_trace.c


    On Tue, 7 Jun 2011, Andi Kleen wrote:

    > From: Andi Kleen <ak@linux.intel.com>
    >
    > rcutree.c defines rcu_cpu_kthread_cpu as int, not unsigned int,
    > so the extern has to follow that.
    >
    > Cc: paulmck@linux.vnet.ibm.com
    > Signed-off-by: Andi Kleen <ak@linux.intel.com>
    > ---
    > kernel/rcutree_trace.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/kernel/rcutree_trace.c b/kernel/rcutree_trace.c
    > index 9678cc3..91c56e5 100644
    > --- a/kernel/rcutree_trace.c
    > +++ b/kernel/rcutree_trace.c
    > @@ -47,7 +47,7 @@
    > #include "rcutree.h"
    >
    > DECLARE_PER_CPU(unsigned int, rcu_cpu_kthread_status);
    > -DECLARE_PER_CPU(unsigned int, rcu_cpu_kthread_cpu);
    > +DECLARE_PER_CPU(int, rcu_cpu_kthread_cpu);

    Can we rather fix the DEFINE to use unsigned int. Signed cpu numbers
    are pointless in that context, right ?

    > DECLARE_PER_CPU(unsigned int, rcu_cpu_kthread_loops);
    > DECLARE_PER_CPU(char, rcu_cpu_has_work);
    >
    > --
    > 1.7.4.4
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/
    >


    \
     
     \ /
      Last update: 2011-06-08 00:45    [W:0.053 / U:0.500 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site