lkml.org 
[lkml]   [2011]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 24/49] Staging: hv: vmbus: Get rid of the unused wrapper - vmbus_onchannel_event()
    Date


    > -----Original Message-----
    > From: Greg KH [mailto:greg@kroah.com]
    > Sent: Tuesday, June 07, 2011 2:59 PM
    > To: KY Srinivasan
    > Cc: Christoph Hellwig; gregkh@suse.de; linux-kernel@vger.kernel.org;
    > devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang;
    > Abhishek Kane (Mindtree Consulting PVT LTD)
    > Subject: Re: [PATCH 24/49] Staging: hv: vmbus: Get rid of the unused wrapper -
    > vmbus_onchannel_event()
    >
    > On Tue, Jun 07, 2011 at 02:59:32PM +0000, KY Srinivasan wrote:
    > >
    > >
    > > > -----Original Message-----
    > > > From: Christoph Hellwig [mailto:hch@infradead.org]
    > > > Sent: Monday, June 06, 2011 7:15 PM
    > > > To: KY Srinivasan
    > > > Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
    > > > devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang;
    > > > Abhishek Kane (Mindtree Consulting PVT LTD)
    > > > Subject: Re: [PATCH 24/49] Staging: hv: vmbus: Get rid of the unused wrapper
    > -
    > > > vmbus_onchannel_event()
    > > >
    > > > On Mon, Jun 06, 2011 at 03:49:48PM -0700, K. Y. Srinivasan wrote:
    > > > > Now, get rid of the unused wrapper - vmbus_onchannel_event().
    > > >
    > > > I'd merge this into the previous patch. In general your patch split
    > > > seem a little too fine grained to me in general. When you remove a
    > > > wrapper you can inline it into the callsite directly, if you clean up a
    > > > function directly inlining it into the helper is fine, etc.
    > > >
    > > I agree with you that some of these patches are too fine grained; but
    > > I thought that was what was expected - "one change per patch".
    >
    > Yes, but don't take it to an extreme, like you have done here :)

    Will do in the future. Should I re-spin any of the patches in this set to make them less
    "fine-grained".

    Regards,

    K. Y



    \
     
     \ /
      Last update: 2011-06-07 22:01    [W:0.025 / U:0.100 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site