lkml.org 
[lkml]   [2011]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 03/10] Add additional isolation mode
    Date
    There are some places to isolate lru page and I believe
    users of isolate_lru_page will be growing.
    The purpose of them is each different so part of isolated pages
    should put back to LRU, again.

    The problem is when we put back the page into LRU,
    we lose LRU ordering and the page is inserted at head of LRU list.
    It makes unnecessary LRU churning so that vm can evict working set pages
    rather than idle pages.

    This patch adds new modes when we isolate page in LRU so we don't isolate pages
    if we can't handle it. It could reduce LRU churning.

    This patch doesn't change old behavior. It's just used by next patches.

    Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    Cc: Mel Gorman <mgorman@suse.de>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    Acked-by: Rik van Riel <riel@redhat.com>
    Acked-by: Johannes Weiner <hannes@cmpxchg.org>
    Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
    ---
    include/linux/swap.h | 2 ++
    mm/vmscan.c | 6 ++++++
    2 files changed, 8 insertions(+), 0 deletions(-)

    diff --git a/include/linux/swap.h b/include/linux/swap.h
    index 48d50e6..731f5dd 100644
    --- a/include/linux/swap.h
    +++ b/include/linux/swap.h
    @@ -248,6 +248,8 @@ enum ISOLATE_MODE {
    ISOLATE_NONE,
    ISOLATE_INACTIVE = 1, /* Isolate inactive pages */
    ISOLATE_ACTIVE = 2, /* Isolate active pages */
    + ISOLATE_CLEAN = 8, /* Isolate clean file */
    + ISOLATE_UNMAPPED = 16, /* Isolate unmapped file */
    };

    /* linux/mm/vmscan.c */
    diff --git a/mm/vmscan.c b/mm/vmscan.c
    index 4cbe114..26aa627 100644
    --- a/mm/vmscan.c
    +++ b/mm/vmscan.c
    @@ -990,6 +990,12 @@ int __isolate_lru_page(struct page *page, enum ISOLATE_MODE mode, int file)

    ret = -EBUSY;

    + if (mode & ISOLATE_CLEAN && (PageDirty(page) || PageWriteback(page)))
    + return ret;
    +
    + if (mode & ISOLATE_UNMAPPED && page_mapped(page))
    + return ret;
    +
    if (likely(get_page_unless_zero(page))) {
    /*
    * Be careful not to clear PageLRU until after we're
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2011-06-07 16:43    [W:4.078 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site