Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 8/8] arch/x86: use printk_ratelimited instead of printk_ratelimit | Date | Tue, 07 Jun 2011 12:41:02 +0930 |
| |
On Mon, 6 Jun 2011 10:11:53 +0200, richard -rw- weinberger <richard.weinberger@gmail.com> wrote: > On Mon, Jun 6, 2011 at 8:35 AM, Rusty Russell <rusty@rustcorp.com.au> wrote: > > On Sat, 4 Jun 2011 17:37:04 +0200, Christian Dietrich <christian.dietrich@informatik.uni-erlangen.de> wrote: > >> Since printk_ratelimit() shouldn't be used anymore (see comment in > >> include/linux/printk.h), replace it with printk_ratelimited. > > > > Acked-by: Rusty Russell <rusty@rustcorp.com.au> (lguest part) > > > >> diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c > >> index db832fd..23a6eff 100644 > >> --- a/arch/x86/lguest/boot.c > >> +++ b/arch/x86/lguest/boot.c > >> @@ -56,6 +56,7 @@ > >> #include <linux/lguest_launcher.h> > >> #include <linux/virtio_console.h> > >> #include <linux/pm.h> > >> +#include <linux/ratelimit.h> > >> #include <asm/apic.h> > >> #include <asm/lguest.h> > >> #include <asm/paravirt.h> > > > > Is this new include really needed? The printk_ratelimited() definition > > is in printk.h... > > Yes. > printk_ratelimited() needs DEFINE_RATELIMIT_STATE() which is defined > in ratelimit.h.
Yech. I'm assuming that making printk.h include ratelimit.h makes a nasty mess?
Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |