Messages in this thread | | | Date | Mon, 6 Jun 2011 16:11:08 -0700 | Subject | Re: [PATCH 3/3] efi: Add support for using efivars as a pstore backend | From | Tony Luck <> |
| |
On Mon, Jun 6, 2011 at 12:38 PM, Matthew Garrett <mjg@redhat.com> wrote: > EFI provides an area of nonvolatile storage managed by the firmware. We > can use this as a pstore backend to maintain copies of oopses, aiding > diagnosis.
Most of the new lines you add to efivars.c should be inside
#ifdef CONFIG_PSTORE ... #endif
so that they don't bloat the kernel if PSTORE isn't configured.
I may have made a poor decision having drivers/acpi/apei/Kconfig do a "select PSTORE" for the ACPI_APEI option. It should probably be a normal "def_bool n" sort of thing.
-Tony
| |