lkml.org 
[lkml]   [2011]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/49] Staging: hv: storvsc: Fix a bug in the storvsc_remove() function
    Date
    When the storvs driver unloads, we need to accomodate disk cache flushes.
    Re-order the code to permit this.


    Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
    Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
    ---
    drivers/staging/hv/storvsc_drv.c | 12 +++++-------
    1 files changed, 5 insertions(+), 7 deletions(-)
    diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
    index 33bce87..fd474d6 100644
    --- a/drivers/staging/hv/storvsc_drv.c
    +++ b/drivers/staging/hv/storvsc_drv.c
    @@ -317,22 +317,20 @@ static int storvsc_remove(struct hv_device *dev)
    struct hv_host_device *host_dev =
    (struct hv_host_device *)host->hostdata;

    + DPRINT_INFO(STORVSC, "removing host adapter (%p)...", host);
    + scsi_remove_host(host);
    +
    + DPRINT_INFO(STORVSC, "releasing host adapter (%p)...", host);
    + scsi_host_put(host);
    /*
    * Call to the vsc driver to let it know that the device is being
    * removed
    */
    storvsc_dev_remove(dev);
    -
    if (host_dev->request_pool) {
    kmem_cache_destroy(host_dev->request_pool);
    host_dev->request_pool = NULL;
    }
    -
    - DPRINT_INFO(STORVSC, "removing host adapter (%p)...", host);
    - scsi_remove_host(host);
    -
    - DPRINT_INFO(STORVSC, "releasing host adapter (%p)...", host);
    - scsi_host_put(host);
    return 0;
    }

    --
    1.7.4.1


    \
     
     \ /
      Last update: 2011-06-07 00:41    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site