Messages in this thread | | | Date | Mon, 6 Jun 2011 22:22:09 +0100 | From | Al Viro <> | Subject | Re: [PATCH] seq_file.h: introduce DECLARE_SEQ_FOPS_{RO,RW} |
| |
On Mon, Jun 06, 2011 at 04:19:15PM -0500, H Hartley Sweeten wrote: > On Monday, June 06, 2011 2:08 PM, Al Viro wrote: > > On Mon, Jun 06, 2011 at 01:19:45PM -0700, H Hartley Sweeten wrote: > >> Many of the procfs and debugfs attribute file_operations in the kernel are > >> missing the .owner information. Introduce some macro's to fill in the .owner > >> field as well as the common methods for virtual file file_operations. This > >> simplifies creating the attributes and makes sure all the fields are properly > >> initialized. > >> > >> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> > > > > Nacked-by: Al Viro <viro@zeniv.linux.org.uk> > > Nacked-because: too ugly > > > > Don't play that kind of games with preprocessor. > > Just an FYI, the exact same thing is being done with DEFINE_SIMPLE_ATTRIBUTE > in fs.h:
Yes, and DEFINE_SIMPLE_ATTRIBUTE is sick and ugly.
| |