Messages in this thread |  | | | Date | Tue, 7 Jun 2011 00:18:14 +0300 | | From | Alexey Dobriyan <> | | Subject | Re: [PATCH] seq_file.h: introduce DECLARE_SEQ_FOPS_{RO,RW} |
| |
On Mon, Jun 06, 2011 at 10:07:55PM +0100, Al Viro wrote: > On Mon, Jun 06, 2011 at 01:19:45PM -0700, H Hartley Sweeten wrote: > > Many of the procfs and debugfs attribute file_operations in the kernel are > > missing the .owner information. Introduce some macro's to fill in the .owner > > field as well as the common methods for virtual file file_operations. This > > simplifies creating the attributes and makes sure all the fields are properly > > initialized. > > > > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> > > Nacked-by: Al Viro <viro@zeniv.linux.org.uk> > Nacked-because: too ugly > > Don't play that kind of games with preprocessor.
3) .owner is ignored for procfs 4) ## breaks grep (and tags) 5) macro name doesn't hint for important "single" piece. 6) DECLARE and DEFINE semi-idioms are used another way :^)
|  |