Messages in this thread | | | Date | Mon, 06 Jun 2011 12:32:05 +0530 | From | Santosh Shilimkar <> | Subject | Re: [PATCH] ARM: omap4: gpio: fix setting IRQWAKEN bits |
| |
On 6/5/2011 12:33 AM, Colin Cross wrote: > Setting the IRQWAKEN bit was overwriting previous IRQWAKEN bits, > causing only the last bit set to take effect, resulting in lost > wakeups when the GPIO controller is in idle. > > Replace direct writes to IRQWAKEN with writes to SETWKUENA and > CLEARWKUEN. > > Signed-off-by: Colin Cross<ccross@android.com>
Looks good. This needs to be fixed on top of the clean-up branch where GPIO movemnt to driver/gpio/* happening.
For this change, Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
| |