lkml.org 
[lkml]   [2011]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sched: remove the next highest_prio in RT scheduling
From
Date
On Sat, 2011-06-04 at 12:44 +0800, Hillf Danton wrote:

> Both the next and curr reach same result, or incorrect result, before locking

Not quite. curr could be of higher priority than this rq, but next be of
lower priority. In that case, we still want to skip the rq.

But this patch does simplify things, and I give you credit for that.
I'll have to run some tests to see how much in practice this occurs, and
see if it is worth removing and using your method instead.

-- Steve

> RQ, as the comment says, it is racy. After locking RQ, priority is checked again
> to pull the correct tasks with no running task included. The difference between
> the next and curr before locking RQ is the core of the patch that incorrect
> result could be achieved with no updating the next field.
>
> thanks
> Hillf




\
 
 \ /
  Last update: 2011-06-04 07:09    [W:0.273 / U:0.604 seconds]
©2003-2014 Jasper Spaans. Advertise on this site