Messages in this thread | | | Date | Sat, 4 Jun 2011 16:25:12 +0900 | From | Minchan Kim <> | Subject | Re: [PATCH] mm: compaction: Abort compaction if too many pages are isolated and caller is asynchronous |
| |
On Fri, Jun 03, 2011 at 05:45:54PM +0200, Andrea Arcangeli wrote: > On Fri, Jun 03, 2011 at 03:49:41PM +0100, Mel Gorman wrote: > > Right idea of the wrong zone being accounted for but wrong place. I > > think the following patch should fix the problem; > > Looks good thanks. > > I also found this bug during my debugging that made NR_SHMEM underflow. > > === > Subject: migrate: don't account swapcache as shmem > > From: Andrea Arcangeli <aarcange@redhat.com> > > swapcache will reach the below code path in migrate_page_move_mapping, > and swapcache is accounted as NR_FILE_PAGES but it's not accounted as > NR_SHMEM. > > Signed-off-by: Andrea Arcangeli <aarcange@redhat.com> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
Nice catch! -- Kind regards Minchan Kim
| |