lkml.org 
[lkml]   [2011]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net/core: Convert to current logging forms
From
Date
On Thu, 2011-06-30 at 09:55 +0000, WANG Cong wrote:
> On Tue, 28 Jun 2011 12:40:10 -0700, Joe Perches wrote:
> > Use pr_fmt, pr_<level>, and netdev_<level> as appropriate.
> > Coalesce long formats.
> > + np->name, np->local_port);
> > + pr_info("%s: local IP %pI4\n",
> > + np->name, &np->local_ip);
> > + pr_info("%s: interface '%s'\n",
> > + np->name, np->dev_name);
> > + pr_info("%s: remote port %d\n",
> > + np->name, np->remote_port);
> > + pr_info("%s: remote IP %pI4\n",
> > + np->name, &np->remote_ip);
> > + pr_info("%s: remote ethernet address %pM\n",
> > + np->name, np->remote_mac);
> > }
> This doesn't have much value, because the name of the netpoll
> user (np->name) is already logged. If we changed it,
> we would see "netconsole: netconsole: blah blah...".

Thanks.

Don't just reply to the lists.
Remember to include the patch author in your replies.

cheers, Joe



\
 
 \ /
  Last update: 2011-06-30 19:13    [W:0.064 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site