Messages in this thread | | | Date | Thu, 30 Jun 2011 09:42:41 -0600 | From | David Ahern <> | Subject | Re: [PATCH -tip 3/4] perf script: add the option to show the offset of symbols |
| |
On 06/29/2011 10:44 PM, Akihiro Nagai wrote: >>>> @@ -346,12 +348,15 @@ static void print_sample_addr(union perf_event >>>> *event, >>>> al.sym = map__find_symbol(al.map, al.addr, NULL); >>>> >>>> if (PRINT_FIELD(SYM)) { >>>> - if (al.sym&& al.sym->name) >>>> + printf(" "); >>>> + if (al.sym&& al.sym->name) { >>>> symname = al.sym->name; >>>> - else >>>> - symname = ""; >>> >>> dropping the else path will cause columns to misalign when ip's do not >>> resolve. > I see. > I'd like to add a magic word that indicates perf-script failed to > resolve the symbol. > For example, '[unknown]'.
ok. constant number of fields would make secondary analysis tools easier.
David
| |