lkml.org 
[lkml]   [2011]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [patch] procfs: returns ENOENT on opening the being-removed proc entry
Hello.

Though I posted the following patch a week ago,
there is no objection, and Kame-san reviewed it.

I hope merge it by someone if possible.
(I don't find maintainer's name for procfs.)

---
I changed the return value to ENOENT.
This return value is then returned when opening the proc entry
that have been removed.
For example, open("/proc/bus/pci/XX/YY") during the corresponding
device is being hot-removed.

Signed-off-by: Daisuke Ogino <ogino.daisuke@jp.fujitsu.com>
---
fs/proc/inode.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/proc/inode.c b/fs/proc/inode.c
index 74b48cf..7ed72d6 100644
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -319,7 +319,7 @@ static int proc_reg_open(struct inode *inode, struct file *file)
if (!pde->proc_fops) {
spin_unlock(&pde->pde_unload_lock);
kfree(pdeo);
- return -EINVAL;
+ return -ENOENT;
}
pde->pde_users++;
open = pde->proc_fops->open;
--
Thanks.
--
Daisuke Ogino




\
 
 \ /
  Last update: 2011-06-30 12:47    [W:0.047 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site