lkml.org 
[lkml]   [2011]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Sound, 6fire: Don't leak firmware in error path
    At Mon, 30 May 2011 12:49:01 +0200 (CEST),
    Jesper Juhl wrote:
    >
    > One of the error paths in
    > sound/usb/6fire/firmware.c::usb6fire_fw_ezusb_upload() neglects to free
    > the memory allocated for the firmware before returning, thus leaking the
    > memory.
    >
    > Signed-off-by: Jesper Juhl <jj@chaosbits.net>

    Applied now. Thanks.


    Takashi

    > ---
    > firmware.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > patch against 3.0-rc1
    > compile tested only
    >
    > diff --git a/sound/usb/6fire/firmware.c b/sound/usb/6fire/firmware.c
    > index d47beff..a91719d 100644
    > --- a/sound/usb/6fire/firmware.c
    > +++ b/sound/usb/6fire/firmware.c
    > @@ -227,6 +227,7 @@ static int usb6fire_fw_ezusb_upload(
    > ret = usb6fire_fw_ihex_init(fw, rec);
    > if (ret < 0) {
    > kfree(rec);
    > + release_firmware(fw);
    > snd_printk(KERN_ERR PREFIX "error validating ezusb "
    > "firmware %s.\n", fwname);
    > return ret;
    >
    >
    > --
    > Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    > Don't top-post http://www.catb.org/jargon/html/T/top-post.html
    > Plain text mails only, please.
    >


    \
     
     \ /
      Last update: 2011-06-03 09:53    [W:0.020 / U:34.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site