lkml.org 
[lkml]   [2011]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] drivers/platform/x86: Fix memory leak
    Date
    data is not freed in the error case of
    compal_probe().

    Signed-off-by: Andre Bartke <andre.bartke@gmail.com>
    ---
    drivers/platform/x86/compal-laptop.c | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)

    diff --git a/drivers/platform/x86/compal-laptop.c b/drivers/platform/x86/compal-laptop.c
    index 3f204fd..8877b83 100644
    --- a/drivers/platform/x86/compal-laptop.c
    +++ b/drivers/platform/x86/compal-laptop.c
    @@ -1030,8 +1030,10 @@ static int __devinit compal_probe(struct platform_device *pdev)
    initialize_fan_control_data(data);

    err = sysfs_create_group(&pdev->dev.kobj, &compal_attribute_group);
    - if (err)
    + if (err) {
    + kfree(data);
    return err;
    + }

    data->hwmon_dev = hwmon_device_register(&pdev->dev);
    if (IS_ERR(data->hwmon_dev)) {
    --
    1.7.5.2


    \
     
     \ /
      Last update: 2011-06-03 20:59    [W:0.042 / U:39.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site