lkml.org 
[lkml]   [2011]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 3/4] ARM: mxc: migrate mach-imx gpio driver to gpio-mxc
    Date
    On Friday 03 June 2011 11:54:14 Fabio Estevam wrote:
    > On Thu, Jun 2, 2011 at 12:33 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
    > ...
    >
    > > +void __init imx1_soc_init(void)
    > > +{
    > > + mxc_register_gpio(0, MX1_GPIO1_BASE_ADDR, SZ_4K, MX1_GPIO_INT_PORTA, 0);
    > > + mxc_register_gpio(1, MX1_GPIO2_BASE_ADDR, SZ_4K, MX1_GPIO_INT_PORTB, 0);
    > > + mxc_register_gpio(2, MX1_GPIO3_BASE_ADDR, SZ_4K, MX1_GPIO_INT_PORTC, 0);
    > > + mxc_register_gpio(3, MX1_GPIO4_BASE_ADDR, SZ_4K, MX1_GPIO_INT_PORTD, 0);
    >
    > By just reading the function names like "imx1_soc_init" we have really
    > no clue of what it actually does.
    >
    > "soc_init" is too vague IMHO. Could´t you change the names to
    > something like "imx1_gpio_init" or "imx1_gpio_register".
    >
    > It would be nice at least are dealing with gpio.

    Olof and I asked Shawn to do it specifically this way, so we have a place
    where more SOC specific initialization can be added without having to
    change every single board file.

    Arnd
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-06-03 15:25    [W:0.020 / U:30.756 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site