lkml.org 
[lkml]   [2011]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4] futex: Fix regression with read only mappings
    On Wed, 29 Jun 2011, Shawn Bohrer wrote:
    >
    > While fixing the regression this patch opens up a possible bad
    > scenarios as identified by KOSAKI Motohiro:
    >
    > This patch also allows FUTEX_WAIT on RO private mappings which have
    > the following corner case.

    These two sentences make no sense at all. We really need a very
    accurate description of this change. That code is subtle and we really
    want to have a very clear and understandable changelog.

    Your changelog fails the basic test by mentioning "corner case" simply
    because the whole futex code consists only of corner cases.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2011-06-30 01:41    [W:0.034 / U:0.004 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site