lkml.org 
[lkml]   [2011]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net, wireless: Don't return uninitialized in __cfg80211_stop_sched_scan()
From
Date
On Wed, 2011-06-29 at 22:42 +0200, Jesper Juhl wrote:
> On Wed, 29 Jun 2011, Luciano Coelho wrote:
>
> > On Wed, 2011-06-29 at 22:27 +0200, Johannes Berg wrote:
> > > On Wed, 2011-06-29 at 22:13 +0200, Jesper Juhl wrote:
> > > > If the 'driver_initiated' function argument to
> > > > __cfg80211_stop_sched_scan() is not 0 then we'll return an
> > > > uninitialized 'ret' from the function.
> > >
> > > 'err'. I also dislike the initialisation, can we just replace the
> > > "return err;" at the end of the function with "return 0;" instead?
> >
> > Luckily we were never using the return value when passing
> > driver_initiate =- false.
> >
> > And I agree with you, there's no use to return err at the end. Better
> > to simply return 0.
> >
> Ok, so how about this?

Fine with me.

johannes




\
 
 \ /
  Last update: 2011-06-29 22:57    [W:0.044 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site