Messages in this thread | | | Date | Mon, 27 Jun 2011 23:32:01 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH] perf, x86: Add hw_watchdog_set_attr() in a sake of nmi-watchdog on P4 |
| |
On Mon, Jun 27, 2011 at 03:03:58PM -0400, Don Zickus wrote: ... > > > Index: linux-2.6.git/kernel/watchdog.c > > =================================================================== > > --- linux-2.6.git.orig/kernel/watchdog.c > > +++ linux-2.6.git/kernel/watchdog.c > > @@ -200,6 +200,8 @@ static int is_softlockup(unsigned long t > > } > > > > #ifdef CONFIG_HARDLOCKUP_DETECTOR > > +void __weak hw_nmi_watchdog_set_attr(struct perf_event_attr *wd_attr) { } > > + > > Though I do wonder about this call in the watchdog. I thought it might be > better elsewhere but not sure where.
Yeah, not the _best_ place. Not sure too where to put it, patches are welcome ;)
> > Cheers, > Don
Cyrill
| |