Messages in this thread |  | | | Date | Tue, 28 Jun 2011 11:10:35 +0100 | | From | Alan Cox <> | | Subject | Re: [PATCH 6/7] serial/8250: sanitize fourport handling |
| |
On Mon, 27 Jun 2011 23:45:19 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
> Support for AST fourport cards is always built into > the 8250 driver, even if CONFIG_SERIAL_8250_FOURPORT > is disabled. This introduces a set of macros for > accessing the special interrupt control register on > the fourport card, so that support is left out > when the option is disabled, without adding more #ifdef > lines to the driver itself.
Why not just leave it in - it seems to take almost no code and your changes mean people setting the fourport flag are going to get strange behaviour when it isn't compiled in.
|  |