lkml.org 
[lkml]   [2011]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][Resend] SCSI, target, loopback: Fix memory leak in tcm_loop_make_scsi_hba()
On Mon, Jun 27, 2011 at 11:54:48PM +0200, Jesper Juhl wrote:
> --- a/drivers/target/loopback/tcm_loop.c
> +++ b/drivers/target/loopback/tcm_loop.c
> @@ -1321,7 +1321,8 @@ struct se_wwn *tcm_loop_make_scsi_hba(
>
> printk(KERN_ERR "Unable to locate prefix for emulated Target Port:"
> " %s\n", name);
> - return ERR_PTR(-EINVAL);
> + ret = -EINVAL;
> + goto out;

You've added a weird bunny hop goto here. It might be better to
change the if (ptr) check to if (!ptr) so we could fall through
here in the normal case.
>
> check_len:
> if (strlen(name) >= TL_WWN_ADDR_LEN) {

If this check fails then it calls kfree() and returns. It would be
cleaner to "goto out" here as well.

regards,
dan carpenter


\
 
 \ /
  Last update: 2011-06-28 00:33    [from the cache]
©2003-2011 Jasper Spaans