lkml.org 
[lkml]   [2011]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH -next] bcma: main.c needs to include <linux/slab.h>
    From
    W dniu 27 czerwca 2011 16:09 użytkownik Geert Uytterhoeven
    <geert@linux-m68k.org> napisał:
    > 2011/6/27 Rafał Miłecki <zajec5@gmail.com>:
    >> 2011/6/26 Geert Uytterhoeven <geert@linux-m68k.org>:
    >>> m68k allmodconfig:
    >>>
    >>> drivers/bcma/main.c: In function ‘bcma_release_core_dev’:
    >>> drivers/bcma/main.c:68: error: implicit declaration of function ‘kfree’
    >>
    >> We already include slab.h in:
    >> host_pci.c
    >> scan.c
    >> sprom.c
    >>
    >> Maybe we can just include this in bcma.h as a better solution? We
    >> could drop other includes then.
    >> Can you submit patch for this?
    >
    > If bcma.h doesn't use linux/slab.h, IMHO it should not include linux/slab.h.

    I guess you want to avoid auto(chain)-including linux/slab.h by bcma
    drivers? OK, just use bcma_private.h instead.

    --
    Rafał
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-06-27 16:15    [W:0.020 / U:1.544 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site