Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 14/19] OpenRISC: Module support | Date | Fri, 24 Jun 2011 20:36:31 +0930 |
| |
On Fri, 24 Jun 2011 12:05:31 +0200, Arnd Bergmann <arnd@arndb.de> wrote: > On Friday 24 June 2011, Jonas Bonn wrote: > > I noticed that kernel/module.c already has this: > > > > unsigned int __weak arch_mod_section_prepend(struct module *mod, > > unsigned int section) > > > > > > Is using a __weak attribute on the default (generic) implementations a > > better approach? > > I normally don't like using __weak, because it more easily confuses > readers about which version is actually used.
I share your reluctance with __weak, but as fewer people want to touch multiple archs it is becoming the norm.
Would happily accept patches...
Thanks, Rusty.
| |