[lkml]   [2011]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 1/3] ptrace: ptrace_reparented() should check same_thread_group()
ptrace_reparented() naively does parent != real_parent, this means
it returns true even if the tracer _is_ the real parent. This is per
process thing, not per-thread. The only reason ->real_parent can
point to the non-leader thread is that we have __WNOTHREAD.

Change it to check !same_thread_group(parent, real_parent).

It has two callers, and in both cases the current check does not
look right.

exit_notify: we should respect ->exit_signal if the exiting leader
is traced by any thread from the parent thread group. It is the
child of the whole group, and we are going to send the signal to
the whole group.

wait_task_zombie: without __WNOTHREAD do_wait() should do the same
for any thread, only sys_ptrace() is "bound" to the single thread.
However do_wait(WEXITED) succeeds but does not release a traced
natural child unless the caller is the tracer.


void *tfunc(void *arg)
assert(ptrace(PTRACE_ATTACH, (long)arg, 0,0) == 0);
return NULL;

int main(void)
pthread_t thr;
pid_t pid, stat, ret;

pid = fork();
if (!pid) {

assert(pthread_create(&thr, NULL, tfunc, (void*)(long)pid) == 0);

assert(waitpid(-1, &stat, 0) == pid);

kill(pid, SIGKILL);

assert(waitpid(-1, &stat, 0) == pid);
assert(WIFSIGNALED(stat) && WTERMSIG(stat) == SIGKILL);

ret = waitpid(pid, &stat, 0);
if (ret < 0)
return 0;

printf("WTF? %d is dead, but: wait=%d stat=%x\n",
pid, ret, stat);

return 1;

Note that the main thread simply does

pid = fork();
kill(pid, SIGKILL);

and then without the patch wait4(WEXITED) succeeds twice and reports

Signed-off-by: Oleg Nesterov <>

include/linux/ptrace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- ptrace/include/linux/ptrace.h~9_ptrace_reparanted_sg 2011-06-22 19:24:13.000000000 +0200
+++ ptrace/include/linux/ptrace.h 2011-06-23 19:21:00.000000000 +0200
@@ -136,7 +136,7 @@ extern bool ptrace_may_access(struct tas

static inline int ptrace_reparented(struct task_struct *child)
- return child->real_parent != child->parent;
+ return !same_thread_group(child->real_parent, child->parent);

static inline void ptrace_unlink(struct task_struct *child)

 \ /
  Last update: 2011-06-24 17:39    [W:0.050 / U:2.212 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site