Messages in this thread | | | Date | Thu, 23 Jun 2011 14:56:07 +0530 | Subject | Re: [PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data | From | Ankur Patel <> |
| |
On Thu, Jun 23, 2011 at 2:38 PM, Jean Delvare <khali@linux-fr.org> wrote: > > On Thu, 23 Jun 2011 14:35:31 +0530, Ankur Patel wrote: > > On Thu, Jun 23, 2011 at 2:15 PM, Jean Delvare <khali@linux-fr.org> wrote: > > > > > On Thu, 23 Jun 2011 13:56:53 +0530, Ankur Patel wrote: > > > > On Thu, Jun 23, 2011 at 1:36 PM, Jean Delvare <khali@linux-fr.org> > > > wrote: > > > > > > > > > On Wed, 22 Jun 2011 07:51:39 +0530, Ankur Patel wrote: > > > > > > From: Ankur Patel <ankur.patel@quipment.in> > > > > > > > > > > > > In the tmp102.ko driver support for 12 bit data is added. Also, the > > > > > > sysfs names are replaced with the actual chip supported fuctionality > > > > > > names. > > > > > > > > > > Nack. These attribute names are standard, see > > > > > Documentation/hwmon/sysfs-interface. You don't get to change them. > > > > > > > > > > > > > > > What problem were you trying to solve? libsensors expects the attribute > > > > > names which are in use today. > > > > > > > > > > Agree, But using temp1_max_hyst as an attribute for presenting low > > > level > > > > threshold, will it not more feasible to use temp1_low instead?. > > > > > > No. This isn't a min temperature limit. Please read the TMP102 > > > datasheet and in particular Figure 10 "Output Transfer Function > > > Diagrams" and the description of the AL configuration bit. > > > > > > Understood. Thank you. I am reverting back the changes for sysfs attribute > > names in the submitted patch to original. Do you have other Issue apart from > > that? > > I didn't read the patch, only the header. So I don't know yet. Just > resubmit and wait for review. > > -- > Jean Delvare
I forgot to switch from HTML to plain text and it get bounced from mailing list. I will resubmit patch soon.
Thank you, Ankur.
| |