lkml.org 
[lkml]   [2011]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[34-longterm 233/247] net: tipc: fix information leak to userland
    Date
    From: Kulikov Vasiliy <segooon@gmail.com>

    -------------------
    This is a commit scheduled for the next v2.6.34 longterm release.
    If you see a problem with using this for longterm, please comment.
    -------------------

    commit 88f8a5e3e7defccd3925cabb1ee4d3994e5cdb52 upstream.

    Structure sockaddr_tipc is copied to userland with padding bytes after
    "id" field in union field "name" unitialized. It leads to leaking of
    contents of kernel stack memory. We have to initialize them to zero.

    Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    net/tipc/socket.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/net/tipc/socket.c b/net/tipc/socket.c
    index cfb20b8..a70214a 100644
    --- a/net/tipc/socket.c
    +++ b/net/tipc/socket.c
    @@ -395,6 +395,7 @@ static int get_name(struct socket *sock, struct sockaddr *uaddr,
    struct sockaddr_tipc *addr = (struct sockaddr_tipc *)uaddr;
    struct tipc_sock *tsock = tipc_sk(sock->sk);

    + memset(addr, 0, sizeof(*addr));
    if (peer) {
    if ((sock->state != SS_CONNECTED) &&
    ((peer != 2) || (sock->state != SS_DISCONNECTING)))
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-06-23 19:47    [W:3.578 / U:0.028 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site