lkml.org 
[lkml]   [2011]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 12/16] sched: prevent interactions with throttled entities
From
Date
On Tue, 2011-06-21 at 00:17 -0700, Paul Turner wrote:
> @@ -2635,8 +2704,10 @@ static int update_shares_cpu(struct task
>
> raw_spin_lock_irqsave(&rq->lock, flags);
>
> - update_rq_clock(rq);
> - update_cfs_load(cfs_rq, 1);
> + if (!throttled_hierarchy(cfs_rq)) {
> + update_rq_clock(rq);
> + update_cfs_load(cfs_rq, 1);
> + }
>
> /*

OK, so we can't contribute to load since we're throttled, but
tg->load_weight might have changed meanwhile?

Also, update_cfs_shares()->reweight_entity() can dequeue/enqueue the
entity, doesn't that require an up-to-date rq->clock?




\
 
 \ /
  Last update: 2011-06-23 13:53    [W:0.376 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site