Messages in this thread |  | | | Date | Wed, 22 Jun 2011 17:22:16 +0200 | | From | Michal Hocko <> | | Subject | Re: [PATCH 2/7] export memory cgroup's swappines by mem_cgroup_swappiness() |
| |
On Thu 16-06-11 12:52:22, KAMEZAWA Hiroyuki wrote: > From 6f9c40172947fb92ab0ea6f7d73d577473879636 Mon Sep 17 00:00:00 2001 > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Date: Wed, 15 Jun 2011 12:06:31 +0900 > Subject: [PATCH 2/7] export memory cgroup's swappines by mem_cgroup_swappiness() > > Each memory cgroup has 'swappiness' value and it can be accessed by > get_swappiness(memcg). The major user is try_to_free_mem_cgroup_pages() > and swappiness is passed by argument. > > It's now static function but some planned updates will need to > get swappiness from files other than memcontrol.c > This patch exports get_swappiness() as mem_cgroup_swappiness(). > By this, we can remove the argument of swapiness from try_to_fre... > > I think this makes sense because passed swapiness is always from memory > cgroup passed as an argument and this duplication of argument is > not very good.
Yes makes sense and it makes it more looking like a global reclaim.
> > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Reviewed-by: Michal Hocko <mhocko@suse.cz>
-- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic
|  |