lkml.org 
[lkml]   [2011]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: code sections beyond .text skipped from alternatives_smp_module_add
> > Looking at the code, in module_finalize for x86, only .text seems to
> > be getting picked for the patching of lock prefixes while other
> > sections such as .exit.text or .init.text are not. Is there a reason
> > we skip the other *.text code sections from the lock patches? Would
> + Gerd Hoffmann who introduced the SMP patching code below back in Jan
> 2006 as part of 2.6.15.

Whoa, long time ago.

>
> Any comments on why patching of smp_lock prefixes should be restricted
> to .text and not other *.text code sections?

It could be that at that time the .exit.text or .init.text did not exist.

As in, the patching code just hasn't kept up. One way of checking that
is just finding the ancient 2.6.15 code and seeing if there is any
mention of those extra segments.

Do you have a patch to fix this?


\
 
 \ /
  Last update: 2011-06-22 15:23    [W:0.067 / U:0.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site