lkml.org 
[lkml]   [2011]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Remove redundant linux/version.h includes from net/
From
From: Jesper Juhl <jj@chaosbits.net>
Date: Tue, 21 Jun 2011 00:13:10 +0200 (CEST)

> It was suggested by "make versioncheck" that the follwing includes of
> linux/version.h are redundant:
>
> /home/jj/src/linux-2.6/net/caif/caif_dev.c: 14 linux/version.h not needed.
> /home/jj/src/linux-2.6/net/caif/chnl_net.c: 10 linux/version.h not needed.
> /home/jj/src/linux-2.6/net/ipv4/gre.c: 19 linux/version.h not needed.
> /home/jj/src/linux-2.6/net/netfilter/ipset/ip_set_core.c: 20 linux/version.h not needed.
> /home/jj/src/linux-2.6/net/netfilter/xt_set.c: 16 linux/version.h not needed.
>
> and it seems that it is right.
>
> Beyond manually inspecting the source files I also did a few build
> tests with various configs to confirm that including the header in
> those files is indeed not needed.
>
> Here's a patch to remove the pointless includes.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Applied, thanks.


\
 
 \ /
  Last update: 2011-06-22 01:07    [from the cache]
©2003-2011 Jasper Spaans