Messages in this thread | | | Date | Tue, 21 Jun 2011 07:43:44 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] configs: Include MODULE_*() when CONFIG_IKCONFIG_PROC=n |
| |
On Mon, 20 Jun 2011 23:12:27 -0700 Stephen Boyd wrote:
> If CONFIG_IKCONFIG=m but CONFIG_IKCONFIG_PROC=n we get a module that has > no MODULE_LICENSE definition. Move the MODULE_*() definitions outside > the CONFIG_IKCONFIG_PROC #ifdef to prevent this configuration from > tainting the kernel. > > Signed-off-by: Stephen Boyd <bebarino@gmail.com> > Cc: Randy Dunlap <rdunlap@xenotime.net>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> --- > kernel/configs.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/configs.c b/kernel/configs.c > index b4066b4..42e8fa0 100644 > --- a/kernel/configs.c > +++ b/kernel/configs.c > @@ -92,8 +92,8 @@ static void __exit ikconfig_cleanup(void) > module_init(ikconfig_init); > module_exit(ikconfig_cleanup); > > +#endif /* CONFIG_IKCONFIG_PROC */ > + > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Randy Dunlap"); > MODULE_DESCRIPTION("Echo the kernel .config file used to build the kernel"); > - > -#endif /* CONFIG_IKCONFIG_PROC */ > --
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
| |