lkml.org 
[lkml]   [2011]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 4/4] Exynos4 NURI: support for NTC thermistor
    On Tue, Jun 21, 2011 at 11:07:13AM +0900, MyungJoo Ham wrote:

    > +#include <linux/platform_data/ntc_thermistor.h>

    This doesn't appear to be in mainline.

    > +/* NTC Thermistor */
    > +static struct platform_device nuri_ncp15wb473_thermistor;
    > +static int read_thermistor_uV(void)

    Blank line between these two.

    > +{
    > + static struct s3c_adc_client *adc;
    > + int val;
    > + s64 converted;
    > +
    > + if (!adc) {
    > + adc = s3c_adc_register(&nuri_ncp15wb473_thermistor,
    > + NULL, NULL, 0);
    > + if (IS_ERR_OR_NULL(adc)) {
    > + pr_err("%s: Cannot get adc.\n", __func__);
    > + return adc ? PTR_ERR(adc) : -ENODEV;
    > + }
    > + }

    Why not do this in an initcall or in the device registration? This
    looks like working around a limitation of the ntc_thermistor driver
    which should be fixed as part of a mainline merge for that.

    > +
    > + if (IS_ERR_OR_NULL(adc))
    > + return adc ? PTR_ERR(adc) : -ENODEV;
    > +
    > + val = s3c_adc_read(adc, 6);
    > +
    > + converted = 3300000LL * (s64) val;
    > + converted >>= 12;
    > +
    > + pr_emerg("%s: %d -> %llduV\n", __func__, val, converted);

    This looks like debug that was left in by mistake.


    \
     
     \ /
      Last update: 2011-06-21 12:53    [W:4.647 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site