lkml.org 
[lkml]   [2011]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] linux/uaccess.h needs to #include linux/kernel.h for might_sleep()
On Wed, 15 Jun 2011 01:22:10 +0100
David Howells <dhowells@redhat.com> wrote:

> linux/uaccess.h needs to #include linux/kernel.h to get might_sleep() otherwise
> it fails to build on MN10300 allyesconfig. This fails in a few places with
> messages like the following:

uaccess.h doesn't textually refer to might_sleep().

> In file included from security/keys/trusted.c:14:
> include/linux/uaccess.h: In function '__copy_from_user_nocache':
> include/linux/uaccess.h:52: error: implicit declaration of function 'might_sleep'

This happened because of arch/mn10300/include/asm/uaccess.h's

#define __copy_from_user(to, from, n) \
({ \
might_sleep(); \
__copy_from_user_inatomic((to), (from), (n)); \
})

> include/linux/uaccess.h | 1 +

So I'd suggest that patching the arch header file is the appropriate fix.



\
 
 \ /
  Last update: 2011-06-21 01:45    [W:0.064 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site