lkml.org 
[lkml]   [2011]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/3] ideapad: Show negative when no camera
    From
    On Thu, Jun 2, 2011 at 11:24 AM, Ike Panhc <ike.pan@canonical.com> wrote:
    > Signed-off-by: Ike Panhc <ike.pan@canonical.com>
    > ---
    >  drivers/platform/x86/ideapad-laptop.c |    5 +++++
    >  1 files changed, 5 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
    > index 9c09891..4a54ed1 100644
    > --- a/drivers/platform/x86/ideapad-laptop.c
    > +++ b/drivers/platform/x86/ideapad-laptop.c
    > @@ -38,6 +38,7 @@
    >  #define CFG_BT_BIT     (16)
    >  #define CFG_3G_BIT     (17)
    >  #define CFG_WIFI_BIT   (18)
    > +#define CFG_CAMERA_BIT (19)
    >
    >  struct ideapad_private {
    >        struct rfkill *rfk[IDEAPAD_RFKILL_DEV_NUM];
    > @@ -199,6 +200,10 @@ static ssize_t show_ideapad_cam(struct device *dev,
    >                                struct device_attribute *attr,
    >                                char *buf)
    >  {
    > +       struct ideapad_private *priv = dev_get_drvdata(dev);
    > +
    > +       if (!test_bit(CFG_CAMERA_BIT, &(priv->cfg)))
    > +               return sprintf(buf, "-1\n");
    >        return show_ideapad_helper(dev, attr, buf, 0x1D);
    >  }
    >
    > --
    > 1.7.4.1
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at  http://vger.kernel.org/majordomo-info.html
    >

    I think it would be better to not add the file when the camera is not
    available. Another option is to return -ENODEV. But printing -1
    doesn't seems right.

    --
    Corentin Chary
    http://xf.iksaif.net
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-06-02 11:45    [W:0.022 / U:31.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site