Messages in this thread | | | Date | Wed, 01 Jun 2011 21:20:36 -0700 (PDT) | Subject | Re: [PATCH 7/10] drivers/net/davinci_emac.c: add missing clk_put | From | David Miller <> |
| |
From: Kevin Hilman <khilman@ti.com> Date: Wed, 01 Jun 2011 12:49:24 -0700
> On Wed, 2011-06-01 at 19:10 +0200, Julia Lawall wrote: >> From: Julia Lawall <julia@diku.dk> >> >> Go to existing error handling code at the end of the function that calls >> clk_put. >> >> A simplified version of the semantic match that finds this problem is as >> follows: (http://coccinelle.lip6.fr/) >> >> // <smpl> >> @r exists@ >> expression e1,e2; >> statement S; >> @@ >> >> e1 = clk_get@p1(...); >> ... when != e1 = e2 >> when != clk_put(e1) >> when any >> if (...) { ... when != clk_put(e1) >> when != if (...) { ... clk_put(e1) ... } >> * return@p3 ...; >> } else S >> // </smpl> >> >> Signed-off-by: Julia Lawall <julia@diku.dk> > > Acked-by: Kevin Hilman <khilman@ti.com>
Applied, thanks.
| |