lkml.org 
[lkml]   [2011]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH] Kexec support for PPC440x
    On 05/31/11 20:45, Sebastian Andrzej Siewior wrote:
    >
    > Suzuki Poulose wrote:
    >> Index: powerpc/arch/powerpc/kernel/44x_kexec_mapping.S
    >> ===================================================================
    >> --- /dev/null
    >> +++ powerpc/arch/powerpc/kernel/44x_kexec_mapping.S
    > ....
    >
    >> + *
    >> + */
    >> + bl nxtins /* Find our address */
    >> +nxtins: mflr r5 /* Make it accessible */
    >
    > Please don't mix labels and instructions.
    OK.
    >
    >> + tlbsx r23,0,r5 /* Find entry we are in */
    >
    > using tabs instead of spaces would make it look nice. Please also separate the arguments of the instruction i.e.
    > tlbsx r23, 0, r5

    Sure.
    >
    >
    >> Index: powerpc/arch/powerpc/kernel/misc_32.S
    >> ===================================================================
    >> --- powerpc.orig/arch/powerpc/kernel/misc_32.S
    >> +++ powerpc/arch/powerpc/kernel/misc_32.S
    >> @@ -736,6 +736,28 @@ relocate_new_kernel:
    >> mr r5, r31
    >>
    >> li r0, 0
    >> +#elif defined(CONFIG_44x) && !defined(CONFIG_47x)
    >> +
    >> + mr r29, r3
    >> + mr r30, r4
    >> + mr r31, r5
    >> +
    >> +#include "44x_kexec_mapping.S"
    >
    > The way you setup the 1:1 mapping should be close to what you are doing on
    > kernel entry.Isn't it possible to include the file here and in the entry
    > code?
    I will make this change and resend the patch.

    Thanks

    Suzuki


    \
     
     \ /
      Last update: 2011-06-02 08:37    [W:0.025 / U:29.748 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site