lkml.org 
[lkml]   [2011]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] sysctl: remove impossible condition check
    On Thu, Jun 2, 2011 at 10:40 AM, Eric W. Biederman
    <ebiederm@xmission.com> wrote:
    >> Looking again at the code, I'm wondering if this is not actually a
    >> bug. There might be entries with procname == NULL, meaning they are
    >> not mirrored in /proc. What seems wrong is the condition in the for().
    >> It should stop when all fields are 0 (meaning the end of the table)
    >> instead of stopping when procname is NULL.
    >
    > It is not a bug.  The condition was originally p->ctlname then
    > it became p->ctlname || p->procname and then finally I was able to
    > kill ctl_name.
    >
    > What you see is a left over that didn't get removed.
    >

    Alright then.

    > This is also the second time in the last couple of weeks someone has
    > sent this patch.
    >
    > There is some ongoing work to make sysctl scale better that with
    > any luck should be ready for 3.1.  Decide which version of this
    > patch you like and please resend, and I will add this to my
    > sysctl tree.

    There's also the same thing in this file, in scan() function. I'll add
    it to the previous patch and resend.

    thanks
    Lucas De Marchi
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-06-02 15:53    [W:0.063 / U:89.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site