lkml.org 
[lkml]   [2011]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 12/19] OpenRISC: Scheduling/Process management
    Date
    On Sunday 19 June 2011 13:43:38 Jonas Bonn wrote:

    > +#if 0
    > +
    > +/*
    > + * The hlt_counter, disable_hlt and enable_hlt is just here as a hook if
    > + * there would ever be a halt sequence (for power save when idle) with
    > + * some largish delay when halting or resuming *and* a driver that can't
    > + * afford that delay. The hlt_counter would then be checked before
    > + * executing the halt sequence, and the driver marks the unhaltable
    > + * region by enable_hlt/disable_hlt.
    > + */
    > +
    > +static int hlt_counter=0;

    This can certainly be removed, it's only used by the floppy driver.

    > +void machine_restart(void)
    > +{
    > + printk("*** MACHINE RESTART ***\n");
    > + __asm__("l.nop 1");
    > +}
    > +
    > +EXPORT_SYMBOL(machine_restart);
    > +
    > +/*
    > + * Similar to machine_power_off, but don't shut off power. Add code
    > + * here to freeze the system for e.g. post-mortem debug purpose when
    > + * possible. This halt has nothing to do with the idle halt.
    > + */
    > +
    > +void machine_halt(void)
    > +{
    > + printk("*** MACHINE HALT ***\n");
    > + __asm__("l.nop 1");
    > +}
    > +
    > +EXPORT_SYMBOL(machine_halt);
    > +
    > +/* If or when software power-off is implemented, add code here. */
    > +
    > +void machine_power_off(void)
    > +{
    > + printk("*** MACHINE POWER OFF ***\n");
    > + __asm__("l.nop 1");
    > +}
    > +
    > +EXPORT_SYMBOL(machine_power_off);
    > +
    > +void (*pm_power_off)(void) = machine_power_off;
    > +EXPORT_SYMBOL(pm_power_off);

    I don't think any of these should be exported.

    Arnd


    \
     
     \ /
      Last update: 2011-06-19 21:15    [W:0.040 / U:0.720 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site