lkml.org 
[lkml]   [2011]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 08/19] OpenRISC: Timekeeping
Date
> + arch/openrisc/kernel/time.c       |  182 +++++++++++++++++++++++++++++++++++++

Would this fit into drivers/clocksource, at least partly?

> +static struct clocksource openrisc_timer = {
> + .name = "openrisc_timer",
> + .rating = 200,
> + .read = openrisc_timer_read,
> + .mask = CLOCKSOURCE_MASK(32),
> + .flags = CLOCK_SOURCE_IS_CONTINUOUS,
> +};
> +
> +static int __init openrisc_timer_init(void)
> +{
> + if (clocksource_register_hz(&openrisc_timer, cpuinfo.clock_frequency))
> + panic("failed to register clocksource");
> +
> + /* Enable the incrementer: 'continuous' mode with interrupt disabled */
> + mtspr(SPR_TTMR, SPR_TTMR_CR);
> +
> + return 0;
> +}

You have soem whitespace damage here. It would be good to run your patches
through scripts/checkpatch.pl and fix up everything reported there.



Arnd


\
 
 \ /
  Last update: 2011-06-19 21:09    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site