lkml.org 
[lkml]   [2011]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/3] net/fec: add device tree support
    On Sat, Jun 18, 2011 at 12:27 PM, Arnd Bergmann <arnd@arndb.de> wrote:
    > On Saturday 18 June 2011 17:19:13 Shawn Guo wrote:
    >> diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt
    >> new file mode 100644
    >> index 0000000..705111d
    >> --- /dev/null
    >> +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt
    >> @@ -0,0 +1,14 @@
    >> +* Freescale Fast Ethernet Controller (FEC)
    >> +
    >> +Required properties:
    >> +- compatible : should be "fsl,<soc>-fec", "fsl,fec"
    >> +- reg : address and length of the register set for the device
    >> +- interrupts : should contain fec interrupt
    >> +
    >> +Example:
    >> +
    >> +fec@83fec000 {
    >> +     compatible = "fsl,imx51-fec", "fsl,fec";
    >> +     reg = <0x83fec000 0x4000>;
    >> +     interrupts = <87>;
    >> +};
    >
    > How about also adding device_type="network" as required here, so you
    > inherit the attributes like "local-mac-address".

    local-mac-address should be used regardless. "device_type" only makes
    sense when a platform uses real OpenFirmware with the runtime services
    api. It should not be used with the flat tree.

    > I would also suggest adding a call to of_get_mac_address() so you
    > can read the address out of the device tree when it is not configured
    > in hardware. Today, the driver relies on a module parameter or
    > platform_data on hardware with a mac address set.

    Yes, of_get_mac_address() is the right thing to do.

    g.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-06-19 02:27    [W:6.825 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site