Messages in this thread | | | Date | Fri, 17 Jun 2011 01:55:40 -0700 (PDT) | Subject | Re: [PATCH/RFC 5/5] usb: Add support for streams alloc/dealloc to devio.c | From | ablay@codeauro ... |
| |
> On Thu, Jun 16, 2011 at 07:28:40PM +0300, Felipe Balbi wrote: >> On Thu, Jun 16, 2011 at 04:31:07PM +0300, Tatyana Brokhman wrote: >> > Allow user space applications such as LIBUSB, to request >> > streams alloc/dealloc from HCD that implements XHCI. >> > >> > Signed-off-by: Amit Blay <ablay@qualcomm.com> >> > Signed-off-by: Tatyana Brokhman <tlinder@codeaurora.org> >> >> other than what Alan said, this needs major splitting. This patch is too >> big. First we need to discuss the ABI details with the guys at >> libusb-devel, then we implement. > > No, we don't break the abi, but rather, create a new one for streams, > and then we can work on adding them to libusb, which should be quite > easy when done. > > thanks, > > greg k-h >
My name is Amit Blay, I'm working with Tatyana Brokhman, I originally created this patch. I want to make sure I understand the solution:
We will create a new IOCTL, i.e., USBDEVFS_SUBMITURB_SS. This IOCTL will pass new URB structure, usbdevfs_urb_ss, which will hold the "legacy" URB and in addition the stream_id. libusb will be able to use the new ABI whenever SuperSpeed streams are required.
Is this correct?
Thanks, Amit Blay, --- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
| |