Messages in this thread |  | | | From | Eric Anholt <> | | Subject | Re: [PATCH 3.0-rc3, v2] i915: Fix gen6 (SNB) GPU stalling | | Date | Fri, 17 Jun 2011 13:39:09 -0700 |
| |
On Sat, 18 Jun 2011 02:20:08 +0800, Daniel J Blueman <daniel.blueman@gmail.com> wrote: > On 18 June 2011 01:44, Eric Anholt <eric@anholt.net> wrote: > > On Sat, 18 Jun 2011 00:42:00 +0800, Daniel J Blueman <daniel.blueman@gmail.com> wrote: > >> Workaround Sandy Bridge GPU stalls by allowing the blitter command streamer > >> to write interrupt state to the Hardware Status Page when a MI_USER_INTERRUPT > >> command is decoded. > >> > >> v1->v2: Moved to prior interrupt handler installation and RMW flags as per > >> feedback. > > > > We shouldn't be RMWing. We're the driver, we're supposed to know what > > we want. I'm backing that bit out, will do another round of testing, > > and send it off. > > I still prefer directly setting the mask due to my earlier reasons. > Unmasking in the IRQ preinstall tests good here, so I'll send a v3 > patch in the morning.
Already tested and sent v3 out to lkml. [unhandled content-type:application/pgp-signature] |  |